Hi all, I'm working to develop a baserule using the following information:

If item is Weapon or Armor, is level greater than x, and has bid/buyout for less than y; then buy/buyout + reason

Here's what I have so far, but it does not appear to be working. I took an example from the wiki page and modified it to what I thought would work.


local level, class
if (level > 60 and class =="Armor" or class == "Weapon" and buyPrice < 40000) then
action="buy"
reason="testing"
end

I'm still new at this, so any criticism or help is appreciated. Thanks

And it would be helpful to actually get the level and class information from somewhere. Like:

local _,_, quality, level, _, class, _,_, equip = GetItemInfo(itemID)

Right now it seems as though you are comparing two empty variables...

I'm making good progess now and getting better results. I believe I am running into a problem where 'level' is actually the itemLevel and not the required level. Is there a way I can differentiate between the two?

Also, even though I list <40000, it appears =40000 still matches.

Just FYI, my current baseRule:

local _,_, quality, level, _, class, _,_, equip = GetItemInfo(itemID)

if (level < 60) then
action="ignore"

elseif (level > 60 and (class =="Weapon" or class == "Armor") and (buyPrice < 40000 or bidPrice < 40000)) then
action="buy"
reason="test"
end


Thanks again, great program.

read http://www.wowwiki.com/API_GetItemInfo

the "use level" is the field between the item level and the class.

Thanks for all the help. I've already learned quite a bit.

Hi,

I'm still trying to get a more in depth understanding of BottomScanner and baserules, so don't shoot me if I go wrong here.

It seems to me there's really not *that* much to play around with:

basePrice = 0

-- ...
-- calculate basePrice; also sets up a base reason such as "Disenchant" that may be appended to below
-- (if basePrice remains zero after this, then don't buy the item for any reason)
-- ...

-- account for AH cut
local resaleValue = basePrice * 0.95
The basePrice you calculate here will always have to be related to some kind of reference price. Be it the constPrice that was used in the past (I really like the Norganna baserule that uses it on the Baserule wiki) or, lacking accurate constPrice data, the auctPrice (and for the adventurers the auctioneer HSP).

I think auctPrice is a good value to use once your database has a reasonable number of items in it and the prices are more or less stable. It is however just about the only value you can use, and then modify it a bit for AH cut and so to get it as close as possible to a really real value for the item. This 'real' value can then be compared (in a number of ways, the buy-near-bid being clever :)) to the bidPrice/buyPrice to determine whether or not a profit can be made, that makes sense.

What still escapes me is how to cleverly recalculate that price and how to find the different reasons for buying/bidding based upon different outcomes. I'm a disenchanter so I'd LOVE to get my hands on a 2nd reference price, being the de-value, but I haven't seen any examples on how to do this and I'm curious how people can decide they want to buy an item for disenchant without this information.

A fixed rule that just buys all green items higher than a certain level and below a certain price will work, but only as long as prices don't shift. Something more dynamic is needed to REALLY make this work. Maybe this is something to wait for with the new Enchantrix.

Onyx.

Actually my valuation code has changed a bit since I posted that. Below's my current getReagentValue function. It ignores my baseline prices (because I kept forgetting to update them :) and instead calculates a value based on historical data, adjusting the value downwards if the snapshot shows a downturn in price.

-- calculate value of a stack of reagents based on
-- auctioneer data and price tables above
local getReagentValue = function(itemID, itemCount)
local base = baselinePrices[itemID]
local adjust = priceAdjustment[itemID] or 1

if not base then return nil end

local median, snapshot, snapshotCount = nil, nil, nil
local _, link = GetItemInfo(itemID)
if link then
local key = Auctioneer.ItemDB.CreateItemKeyFromLink(link)
if key then
median = Auctioneer.Statistic.GetItemHistoricalMedianBuyout(key)
snapshot, snapshotCount = Auctioneer.Statistic.GetItemSnapshotMedianBuyout(key)
end
end

median = median or base
snapshot = snapshot or base
snapshotCount = snapshotCount or 1

local snapshotWeight = 0
if snapshotCount >= 5 and snapshot < median then
snapshotWeight = math.log10(snapshotCount) / math.log10(50)
end
snapshotWeight = math.min(math.max(snapshotWeight, 0), 1)
local medianWeight = 1 - snapshotWeight

local combined = median * medianWeight + snapshot * snapshotWeight
return combined * adjust * itemCount
end

Ehhh. Chardonay I know I'm repeating myself, but could you post your baserule on the wiki in the baserule-scratch. After reading this I really think having your baserule there could be an inspiration for a lot of stuff that people are (at least at what I'm) thinking on.

Your bug is here I think:
if (level > 66 and class =="Armor" or class == "Weapon") then
"and" has higher precedence (http://en.wikipedia.org/wiki/Order_of_operations, http://www.lua.org/pil/3.5.html) than "or", making that line equivalent to:
if ((level > 66 and class =="Armor") or class == "Weapon") then
so you'll get armor with the levels you want, but weapons of any level. You can add another pair of parentheses to force the correct ordering:
if (level > 66 and (class =="Armor" or class == "Weapon")) then

I'm am getting a similar problem and I am, too, a very unexperienced coder. Part of my baserule is as follows:

local _,_, quality, level, _, class, _,_, equip = GetItemInfo(itemID)
if (quality == 2 and (level > 56 and level < 81) and class == "Armor") then
if buyPrice ~= 0 and buyPrice < 45000 then
action = "buy"
reason = "BO armor"
elseif bidPrice < 44000 then
action = "bid"
reason = "BID armor”
end
end

The problem I am having is that although, in my eyes, I have clearly defined the item-levels (more than level 56 but less then 81) still items of lower levels come up. Anyone have an idea?

how much lower? remember, you are looking at item level, not use level.

Bonafide, you can easily confirm that by checking reason for those "extra" items. if it is not "BO armor" or "BID armor" defined in your rule, then you see items picked up by default rules.