Not signed in (Sign In)

Support::Gatherer: Minimap button issue?

Bottom of Page

1 to 5 of 5

  1.  
    •  
      CommentAuthorDeckard
    • CommentTimeMar 2nd 2007
     
    (Reposting this to its own thread and edited for clarity, hoping for an answer) :bigsmile:

    I was checking the patch notes for MinimapButtonBag (allows placing of all minimap buttons into a single one that can be expanded), and noticed this bit of info detailing why the mod won't work with Gatherer's button by default:

    The Gatherer button has the same problem as the CTMod2 button. Edit the Gatherer/GatherMiniIcon.lua file and change line 33 from:
    local miniIcon = CreateFrame("Button", "", Minimap);
    to
    local miniIcon = CreateFrame("Button", "GathererMinimapButton", Minimap);

    -------

    I don't use MinimapButtonBag, but I do use DetachedMiniButtons, and I have a square minimap moved from the default position. I've modified GatherMiniIcon.lua as noted above, and it does fix the issue for DetachedMiniButtons as well. So my question is, can this be changed in Gatherer permanently to allow these mods to hook Gatherer's minimap button, or is there a good reason for leaving as is? I can't tell if this was just an oversight or intentional by design.

    Thanks for any help with this.
    •  
      CommentAuthorDeckard
    • CommentTimeApr 22nd 2007
     
    Never got an answer on this, bumping for help. I'm just curious about this, as it would allow Gatherer's minimap button to interoperate with mods that move those buttons.
    •  
      CommentAuthordinesh
    • CommentTimeApr 23rd 2007
     
    deckard, rather than keep bumping this, i'd suggest you go into IRC and look for esamynn, norgs, or islorgris.
  4.  
    Its intentional, you see when a frame is named, its name is not only used for the :GetName() function, but is also added to the global name space as a reference to that frame. This is not a desirable thing when you're going for speed and cleanliness of code. What AddOns that need references to those frames could do is offer a global table that minimap button-generating AddOns could add a reference to. That would solve the problem without polluting the global name space more than it needs to be.
    •  
      CommentAuthorDeckard
    • CommentTimeApr 25th 2007
     
    Thanks for the explanation MP. I don't fully understand it, but at least I know it's intentional.

1 to 5 of 5

  1.  
World of Warcraft™ and Blizzard Entertainment™ are trademarks or registered trademarks of Blizzard Entertainment, Inc. in the U.S. and/or other countries.