Not signed in (Sign In)

BottomScanner::Discussion: Idea: Filter by BeanCount Succeeded/Failed

Bottom of Page

1 to 39 of 39

  1.  
    • CommentAuthoralcaras
    • CommentTimeMar 30th 2008
     
    Just a small little idea that came to me this morning -- would it be possible to create a BottomScanner Filter that would not bid on items that had below a certain ratio of Succeeded/Failed in BeanCounter?

    Using this filter, one could make it so BottomScanner doesn't bid on seemingly good deals that haven't been selling.
    • CommentAuthorRockSlice
    • CommentTimeMar 30th 2008
     
    It would be possible. Want to write one?
    • CommentAuthoralcaras
    • CommentTimeMar 30th 2008
     
    Sure. I've never written a filter before, but I can try my hand at it now that I know it'd be possible :)
    • CommentAuthorRockSlice
    • CommentTimeMar 30th 2008
     
    my suggestion is to start by copying the base framework of a current filter, and building off of that.

    Also, for the ratio, look at MatchBeancount.lua in BeanCounter.
    • CommentAuthormattbnr
    • CommentTimeMar 30th 2008
     
    as far as beancount is concerned is there a future idea of making the % selectable by class. such as make armor/weapons adjustable by 1% increments but still have enchant mats go by .1% increments.
    • CommentAuthorKinesia
    • CommentTimeMar 31st 2008
     
    alcaras that would be very cool.
    I have a lot of things that haven't been selling...
    The latest match beancount stuff has added a check for "last 30 days of results" and that'd be useful in your filter too.
    • CommentAuthoralcaras
    • CommentTimeApr 3rd 2008 edited
     
    I have a raw version working, named FilterHotcakes, since you want to filter to select stuff that sells like hotcakes... ;)

    Not sure what to do with it in terms of submitting it to the svn, but I uploaded it here:
    http://norganna.org/up/show.php/viQhTX/FilterHotcakes.lua

    To get it working, put that into its own FilterHotcakes.lua file in BtmScan's directory and add a reference to it in btmScan.toc.

    Thanks for everyone's help and advice :)
    • CommentAuthorKinesia
    • CommentTimeApr 4th 2008
     
    Looks like a good start!
    I'm having a problem with it though...
    If I turn on the Verbose mode and start mousing over things in my bag it _always_ says failed regardless of if the Ratio is higher or lower than 0.5
    • CommentAuthoralcaras
    • CommentTimeApr 5th 2008
     
    Hmm, I haven't experienced that. Try changing the ratio around and see if that changes anything (it shouldn't but perhaps the defaults aren't being properly initialized).

    Also, here is my most current version (Verbose mode only shows filtered):
    http://up.norganna.org/show.php/9G8R4N/FilterHotcakes.lua

    Perhaps I somehow changed something between versions that fixes that.
    • CommentAuthorKinesia
    • CommentTimeApr 6th 2008
     
    Ok, looks to work a bit better now in that regard.
    Mousing over something in my bag with Verbose on prints out the failed line 6 times for each item (when it does fail, it's no longer doing that all the time)

    Also if I've got 0 successes for something and 1 failure it thinks the success rate is 0, which technically it is, but I don't think that's enough data to decide I don't want to buy them...
    Could you add a minimum of 10 total success/fail figures before it counts or something like that perhaps?
    • CommentAuthoralcaras
    • CommentTimeApr 6th 2008
     
    Yep, once I have some more free time, I'll look into adding a minimum count. Thanks for the suggestion :)
    • CommentAuthoralcaras
    • CommentTimeApr 13th 2008
     
    New version, includes a minimum threshold:
    http://up.norganna.org/show.php/rf5p38/FilterHotcakes.lua
    • CommentAuthorKinesia
    • CommentTimeApr 13th 2008
     
    Thanks for that!
    Now I can finally stop buying more Red Helper Boxes from Christmas!

    (I don't seem to be able to click "No" or "Ignore" when BTM tells me something is a bargain... Much better if I don't see them in the first place!)
    • CommentAuthorKinesia
    • CommentTimeApr 14th 2008
     
    I added a variable at the top:
    local filtered = {}

    and then changed the verbose printing to:

    if verbose then
    if not filtered[sLink] then
    BtmScan.Print("Hotcakes: Filtered: "..tostring(sLink)..". "..s.." successes, "..f.." failed. Ratio: "..tostring(actual_ratio).." did not meet minimum ratio of "..tostring(target_ratio))
    filtered[sLink] = 1
    end
    end


    Then it only prints each line once instead of 6 times. (It really shouldn't be calling your filter 6 times on each item, but that's not your fault!)
    • CommentAuthoralcaras
    • CommentTimeApr 14th 2008
     
    Thanks, I was wondering why it was doing that...
    • CommentAuthorKinesia
    • CommentTimeMay 4th 2008
     
    alcaras, Beancounter was updated recently so you may need to tweak this for it to continue working.
    • CommentAuthoralcaras
    • CommentTimeMay 5th 2008 edited
     
    Uploaded an updated version:
    http://up.norganna.org/index.php/l3dONto/FilterHotcakes.lua

    Remember to update your BtmScan.toc to add in FilterHotcakes.lua.
    • CommentAuthorKinesia
    • CommentTimeMay 5th 2008
     
    Thanks. Yeah, I have a few extra things in my toc file, though I think this is the only one I still have turned on... The others were all experiments that didn't quite work out!
    I continue to find this very useful though. I knew straight away it wasn't working anymore because I started getting offers for "Pattern Living Earth Shoulders" and thought, "What! I don't want any of those!"
    • CommentAuthorKinesia
    • CommentTimeMay 5th 2008
     
    Oh, I'm fairly extreme in my settings by the way... I have it set to filter things out at 0.5% after seeing it a minimum of 50 times...
    So it doesn't trigger for too much at all, but it's important when it does.
    • CommentAuthoralcaras
    • CommentTimeMay 5th 2008 edited
     
    I'm extreme the other way, I have it at 0.2 after a minimum of 2 times :P
    • CommentAuthorKinesia
    • CommentTimeMay 8th 2008
     
    Try this one:

    http://up.norganna.org/index.php/l276WeM/FilterHotcakes.lua


    I shuffled the caching around so it shouldn't bother looking things up more than once.
    • CommentAuthormattbnr
    • CommentTimeMay 13th 2008 edited
     
    so is this "filter" really only useful for reselling items? as i don't see the point in having it on disenchant or prospecting or vendoring or snatch.well maybe snatch but not the others.

    nexus crystal

    ok why is it "filtering" nexus crystal when im not looking for it as i only have my vendor enabled?
    • CommentAuthortestleK
    • CommentTimeMay 13th 2008
     
    mattbnr, my guess is filters are run on every item BEFORE the item actually gets to the evaluators, so even if you have an evaluator disabled the item will still run through the filter. Also, yeah I would probably only apply that filter to re-auction same item type of evaluators and not de, prospect, vendor, or snatch... I add snatch in there because if its in snatch you clearly want the item for some reason else you can just remove it from snatch
    • CommentAuthortestleK
    • CommentTimeMay 13th 2008
     
    alcaras, this is actually really cool, have you thought about joining the team and contributing the code to be distributed as part of the full package?
    • CommentAuthorKinesia
    • CommentTimeMay 13th 2008
     
    The filters seem to run even when the tooltips are being generated which I find a bit odd!

    And yes, only useful for reselling.
    • CommentAuthortestleK
    • CommentTimeMay 13th 2008
     
    I think they run even with just tooltips because we push all of btm(evaluators too for valuations) against it (mostly) it seems, however filters could indeed be left out of simple tooltip generation (unless theres a valid argument against it?)
    • CommentAuthormattbnr
    • CommentTimeMay 18th 2008
     
    along the lines of filtering according to fail- success ratio is there a way to have automagic change its suggestion according to the fail to success ratio as well? i think that would be a great feature. i mean if you have tried to sell the thing 10 times and have failed 10 times maybe its time to disenchant the item.
    • CommentAuthortestleK
    • CommentTimeMay 18th 2008
     
    actually it is indeed coming to an Item Suggest module near you, I have just been pondering its implementation. The problem is that this filter is not 'standard' in the package so using it doesn't work. I will have to do basically what it does on its own but it won't be until after I get a confirmation dialog and ability to 'ignore' items for autosell so that I can push ItemSuggest into AutoSell before I get the chance to get around to something like that... although there should be a jira made for it to spark my memory
    • CommentAuthormattbnr
    • CommentTimeMay 18th 2008
     
    if you would like me to make a jira for you i would be happy to ill just link back here to jog your memory. there we go http://jira.norganna.org/browse/PLVL-2
    • CommentAuthortestleK
    • CommentTimeMay 20th 2008
     
    ty
    • CommentAuthoralcaras
    • CommentTimeJun 7th 2008
     
    Posted By: testleKalcaras, this is actually really cool, have you thought about joining the team and contributing the code to be distributed as part of the full package?


    Sure; what do I need to do?

    Sorry for being away, finals/moving :P
    • CommentAuthorRockSlice
    • CommentTimeJun 7th 2008
     
    Posted By: alcarasSure; what do I need to do?
    Join us on IRC (http://norganna.org/irc/), channel #norganna-dev, and make yourself known to one of the ops there.
    • CommentAuthoralcaras
    • CommentTimeJun 9th 2008
     
    •  
      CommentAuthordinesh
    • CommentTimeJun 10th 2008
     
    sure, you're a dev now. the way you add new features is by committing to SVN. best bet is to discuss your change in IRC-dev first, and whoever is online will walk you through the process the first time. you'll probably get beaten by global pollution at first...heh.
    • CommentAuthorNials
    • CommentTimeJul 22nd 2008
     
    Very nice module. This will definitely help me filter out shoddy deals :)
    • CommentAuthoralcaras
    • CommentTime1 day ago edited
     
    A beta version of Hotcakes as a SearchUI filter:
    http://up.norganna.org/show.php/dMTPFv/FilterItemAuctionHistory.lua

    To get this working, you'll need to put it in:
    Interface\Addons\Auc-Advanced\Modules\Auc-Util-SearchUI
    Also edit Embed.xml to add:
    <Script file="FilterItemAuctionHistory.lua"/>


    Thanks to RockSlice, dinesh, Aesir, and Kandoko for their help in converting it.

    Once 3.0.2 comes out on Live, I'll do some final testing and add it to the SVN.
    • CommentAuthormattbnr
    • CommentTime1 day ago edited
     
    i realize this is in "beta" stage a help file would be nice to explain what all the numbers mean. like.2 success/fail ratio what exactly the filter does what not.

    edit: I figured out what the .02 means. its saying for every 10 items you post you sold 2 of them. don't bid/buyout anything that is less then this i.e. 1 sold for every 10 posted. am i right?

    edit: also the mouseover tooltips are copy/pasted from timeleft filter so might wanna change/remove those.
    • CommentAuthormattbnr
    • CommentTime1 day ago
     
    here is how i had to set up the embed file in SearchUI folder.

    add this to the embed file under the FilterItemPrice line <script file="FilterHotCakes.lua"/>

    and name your file FilterHotCakes.lua all worked fine after that.
    • CommentAuthoralcaras
    • CommentTime1 day ago
     
    If you have any ideas for better labels in game, I'd love to hear them.

    I'd rather have the interface make sense right away rather than ask people to read a forum post to explain it, and I'm not happy with the interface's explanation of itself right now.

1 to 39 of 39

  1.  
World of Warcraft™ and Blizzard Entertainment™ are trademarks or registered trademarks of Blizzard Entertainment, Inc. in the U.S. and/or other countries.