Not signed in (Sign In)

Support::Informant: support for spelllink tooltips

Bottom of Page

1 to 20 of 20

  1.  
    • CommentAuthorlilsparky
    • CommentTimeMay 27th 2008 edited
     
    i notice that i get informant tooltips for price breakdowns on the yellow enchant links, but not on the cyan spell links for the same spell/enchant. as a mod author, getting a spelllink is much easier than getting an enchant link if you have a spell id, so i would expect more and more spell links to show up in place of enchant links. i've been trying to figure out how to convert between the two and finally decided it would be best if tooltip mods would simply support spelllinks when applicable.

    thoughts?

    (btw, i think i understand that this is actually enchantrix providing this info, but i'm not totally certain...)
    • CommentAuthorlilsparky
    • CommentTimeMay 27th 2008 edited
     
    okay, so i guess the pertinent code is enchantrix and not informant (wasn't sure if it was informant deciding what needed to be called or enchantrix deciding what needed to be registered).

    in the hooktooltip function i changed:

    elseif ltype == "enchant" then

    to

    elseif ltype == "enchant" or ltype == "spell" then


    and it seems to work. doesn't explode on the few non-enchant spells i sent it either.


    edit: for some reason, i seem to always confuse informant with enhtooltip. i was thinking this might be an enhtooltip issue, not an informant issue... and it's an enchantrix issue. lord. this is obviously in the wrong place.
    • CommentAuthorccox
    • CommentTimeMay 28th 2008
     
    Enchantrix won't be able to get the item breakdown for everything because of differences in the descriptions.
    Enchantrix tries to get the info from the spell (if the current toon know it) or the tooltip. But it's setup to search for strings found in enchanting and a few crafting descriptions only. I've tried to make it do more, but ran into a few roadblocks. Maybe Blizzard has fixed those by now and we can try again, but it may take more than a few changes. Also, you may find some code in there for non-enchants that caches results and my notes about needing to do recursive searches for some crafted items (since the price of making a bolt of cloth is different than buying a bolt of cloth, etc.).
    • CommentAuthorlilsparky
    • CommentTimeMay 28th 2008
     
    hmm... sure, i get what you're saying. but my question was really about the spell links vs enchant links.

    i'm working on an update for skillet which uses spell id's internally to store data. because i've got all that data around, when somebody wants the recipe link, i produce a blue spelllink from the spell id instead of making the call to the tradeskill/crafting api. the information in the link is identical, only the color is different. however, enchantrix is only looking for "enchant" or "item" links and not "spell" links. i was just asking to have it also work with the blue spell links as well as the yellow enchant links.
    • CommentAuthorccox
    • CommentTimeMay 28th 2008
     
    I wasn't quite sure what you were asking for, since you made a statement instead of asking for a feature.
    I was trying to give you enough information to complete your investigation, hoping you'd tell us what you were really looking for.
    • CommentAuthorlilsparky
    • CommentTimeMay 29th 2008
     
    hmmm...

    i'm looking for enchantrix to parse spelllinks as well as enchantlinks. the 2nd post contains the code i slapped into my local copy of enchantrix (in the tooltip hooking code, sorry don't know the specific file off hand). it seems to function without causing errors for non-enchant spelllinks, but i don't know the ins and outs to know if it's kosher to just slap that in there.
    • CommentAuthorccox
    • CommentTimeMay 29th 2008
     
    file it in JIRA, and I'll give it a shakedown this weekend
    •  
      CommentAuthorNechckn
    • CommentTimeMay 29th 2008
     
    CCox,

    Lil'Sparky did create a ticket, http://jira.norganna.org/browse/ENX-41. Linked the ticket to the discussion, as well.

    Bon chance,

    Nikk :shades:
    • CommentAuthorccox
    • CommentTimeMay 30th 2008
     
    Do you have a reliable way of producing the cyan spell links? (all the methods I know of generate the yellow links, so maybe I'm missing something)
    • CommentAuthorKinesia
    • CommentTimeJun 1st 2008
     
    Shift-clicking from your spell book makes the blue links. It's only a recent development...
    • CommentAuthorccox
    • CommentTimeJun 1st 2008
     
    Sparky is talking about trade skills giving spell links - and that's what I need to test.

    Shift-clicking on spells in trade skills gives the same old yellow link as it always has, unless I'm missing something.
    • CommentAuthorKinesia
    • CommentTimeJun 1st 2008
     
    I can't work out how to get the links for them unfortunately...
    But the thing you cast when you use a tradeskill is actually a spell internally. (Wowhead and thotbott have them listed)
    I just haven't a clue how to get those to show, because as you say you usually just get the normal yellow link.

    Sparky, how are you generating blue ones to start with?
    • CommentAuthorlilsparky
    • CommentTimeJun 10th 2008
     
    srry for not getting back here sooner.

    i'm generating them from my own custom branch of skillet (which i'm hoping to merge into the main branch soon). i'm using spell id's pulled from the crafting/tradeskill recipe links as the internal key for recipes and then simply calling "GetSpellLink(recipeID)" to generate the link i need. because i allow browsing of alts, i can't rely on the tradeskill api being available and since i've already got the spell id, i just go ahead and use the new api call to generate the link.

    it's identical to the yellow ones, only it's blue and has "spell:" instead of "enchant:"... at least, that's the only difference i can detect.

    for a quick and easy test:

    /script DEFAULT_CHAT_FRAME:AddMessage(GetSpellLink(27927))

    same blizzard tooltip, only no extra window from enchantrix.
    • CommentAuthorccox
    • CommentTimeJun 10th 2008
     
    Ok, so the only good way to generate them right now is to write some code.
    Sigh.
    Hmm, wonder if I can hack some other addon to do that for me.....
    • CommentAuthorlilsparky
    • CommentTimeJun 10th 2008
     
    do you use a tradeskill mod? probably wouldn't be too hard to hack it to spit out spell links...
    • CommentAuthorccox
    • CommentTimeJun 11th 2008
     
    Yeah, ATSW - that's what I was thinking of modding.
    • CommentAuthorccox
    • CommentTimeJun 13th 2008
     
    Well, ATSW doesn't generate the links, just has Blizz generate them and add to chat.

    To save me a few hours of hacking: do you have a reliable way to generate spell links?
    • CommentAuthorbrykrys
    • CommentTimeJun 14th 2008 edited
     
    The spell ID does indeed appear to be the same as the enchant ID, as displayed in the enchantrix tooltip (just the number part)

    Give the following code a TOC, and you can use the slash command (/slink) to feed in either numbers or crafting links (my idea is you can quickly generate a lot of spell links by shift-clicking your crafting links into the slash command).


    local function Slash (text)
    text = text or "" -- make sure not nil
    local link = GetSpellLink (tonumber (strmatch (text, ":(%d+)") or strmatch (text, "(%d+)") or "") or "") or "<unknown>"
    DEFAULT_CHAT_FRAME:AddMessage ("Slink: Link = "..link, 0, 1, 0)
    end

    SLASH_Slink1 = "/slink"
    SlashCmdList["Slink"] = Slash



    By the way, if anyone can tell me how to obtain a spellID from an arbitrary tooltip, I'd love to know :)
    • CommentAuthorccox
    • CommentTimeJun 14th 2008
     
    ok, so far that's working, and enchantrix / barker is handling them correctly
    • CommentAuthorccox
    • CommentTimeJun 14th 2008
     
    Ok, now committed with revision 3167

1 to 20 of 20

  1.  
World of Warcraft™ and Blizzard Entertainment™ are trademarks or registered trademarks of Blizzard Entertainment, Inc. in the U.S. and/or other countries.